Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support email for nvml integration #2353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update support email for nvml integration #2353

wants to merge 1 commit into from

Conversation

mirzanurkic-dd
Copy link

What does this PR do?

Updates the nvml check support and sales email address in manifest.json

Motivation

Hi @cep21,

I'm a support engineer at Datadog, and recently had a customer reach out because the nvml integration stopped working with the most recent Datadog Agent. As you're listed in the CODEOWNERS file, I wanted to update the manifest.json to match and make it clearer for users of this integration to contact you for similar issues. This matches other integrations in the repo - no update to the README.md.

If you do not agree to this, please let me know. I'll then work to make sure this integration is marked as orphaned instead, to prevent anyone from reaching out to you in future.

Internal ticket reference (not publicly viewable): https://datadog.zendesk.com/agent/tickets/1645334

The error in question, for reference:

2024-04-12 05:47:11 UTC | CORE | DEBUG | (pkg/collector/python/loader.go:157 in Load) | Unable to load python module - datadog_checks.nvml: unable to import module 'datadog_checks.nvml': Traceback (most recent call last):
  File "/opt/datadog-agent/embedded/lib/python3.11/site-packages/datadog_checks/nvml/__init__.py", line 5, in <module>
    from .nvml import NvmlCheck
  File "/opt/datadog-agent/embedded/lib/python3.11/site-packages/datadog_checks/nvml/nvml.py", line 16, in <module>
    from .api_pb2 import ListPodResourcesRequest
  File "/opt/datadog-agent/embedded/lib/python3.11/site-packages/datadog_checks/nvml/api_pb2.py", line 25, in <module>
    _LISTPODRESOURCESREQUEST = _descriptor.Descriptor(
                               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/datadog-agent/embedded/lib/python3.11/site-packages/google/protobuf/descriptor.py", line 296, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

This was resolved with:
sudo -u dd-agent -H /opt/datadog-agent/embedded/bin/pip3 install grpcio pynvml==11.5.0 protobuf==3.20.3

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@mirzanurkic-dd mirzanurkic-dd requested a review from a team as a code owner April 15, 2024 22:52
@maxgio92
Copy link

maxgio92 commented Nov 26, 2024 •
edited
Loading

Hi @mirzanurkic-dd, I think my PR #2535 is introducing the support you were looking for.

Also, is this PR like #2535 not merged because of missing approval from approver with write access? cc @cswatt

@hkrutzer
Copy link

On #2535 (review) @cep21 writes

The PR is fine, but I'm unable to maintain this module anymore. Can I be removed from the maintainers?

so it should probably be marked orphaned.

@maxgio92
Copy link

I'm wondering if there's any repository-wide approver user to fallback to to unblock these contributions. It would be pretty unusual otherwise to have stale but approved PRs

@cep21
Copy link
Contributor

cep21 commented Dec 23, 2024

Hi

If you do not agree to this, please let me know. I'll then work to make sure this integration is marked as orphaned instead, to prevent anyone from reaching out to you in future.

Sorry I cannot maintain this anymore :( Good luck! Maybe the code could point people towards https://www.datadoghq.com/blog/monitor-nvidia-gpus-with-datadog/#start-monitoring-your-gpu-powered-workloads

I wrote this plugin before nvidia support was as supported as it is now.

cep21
cep21 suggested changes Dec 23, 2024
View reviewed changes
nvml/manifest.json
"homepage": "https://github.com/DataDog/integrations-extras",
"sales_email": "help@datadoghq.com",
"sales_email": "cep221@gmail.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just deprecate and point people towards https://www.datadoghq.com/blog/monitor-nvidia-gpus-with-datadog/#start-monitoring-your-gpu-powered-workloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cep21 cep21 cep21 requested changes

@cswatt cswatt cswatt approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirzanurkic-dd @maxgio92 @hkrutzer @cep21 @cswatt